bugfix: Prevent ranking of riders that are not trainable #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Dec 10, 2025
| return FALSE; | ||
|
|
||
| #if !RETAIL_COMPATIBLE_CRC | ||
| const ContainModuleInterface* contain = other->getContain(); |
| return FALSE; | ||
|
|
||
| // Sorry, you can't gain levels | ||
| if( !other->getExperienceTracker()->isTrainable() ) |
There was a problem hiding this comment.
Seeing these conditions now used at 2 places, how about add a function in Object for "eligibleForLevelUp" and then call that here and in CommandXlat? This way the conditions stay in sync.
Author
There was a problem hiding this comment.
I did consider this, but as one of the usages is debug logic, I thought it would not really be that useful.
There was a problem hiding this comment.
I probably would add a Object::isTrainable, since it has this intricacy with the Rider.
Stubbjax
force-pushed
the
fix-rider-trainability
branch
from
30f557c to
fce6f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue that allows riders to rank up even if they are not trainable. For example, a player might place a Worker on a Combat Cycle and then drive over a Salvage Crate.
Before
A mounted Worker ranks up when driving over a Salvage Crate
RANKED_WORKER.mp4
After
Only trainable mounted units can rank up
TRAINABLE_VET.mp4
Note: The changes to Generals are solely for unification. Riders do not exist there.