Default log level name style to use bright black #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black text is not visible on black terminals. Using black color as a default might not be visible on many setups out there (a lot of developers use black backgrounds). Using dark gray color (bright black) seems like a reasonable compromise if log level is chosen to be dark by default.
There was a problem hiding this comment.
Pull request overview
This PR improves the visibility of log level names in colored terminal output by changing the default color from black to bright black (dark gray). This addresses a common issue where black text is invisible on terminals with dark or black backgrounds, which are widely used by developers.
Key Changes:
- Added
bright=Trueparameter to thelevelnamefield style inDEFAULT_FIELD_STYLES, making the log level name appear in bright black (dark gray) instead of plain black
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black text is not visible on black terminals. Using black color as a default might not be visible on many setups out there (a lot of developers use black backgrounds). Using dark gray color (bright black) seems like a reasonable compromise if log level is chosen to be dark by default.
Changes tested on all built-in color schemes of Gnome Terminal, and the log level is visible on all of them. What's the most important, it is visible on black themes of other terminal like Kitty or Putty.
Fixes #77