-
-
Notifications
You must be signed in to change notification settings - Fork 696
feat: introduce -error versions of configs that have all rules configured to error
#2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
G-Rath
wants to merge
14
commits into
vuejs:master
Choose a base branch
from
G-Rath:support-erroring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ee9f8a0
feat: support using `error` instead of `warn` for rules in config
G-Rath 4dcb8ff
feat: regenerate configs
G-Rath b5a434e
feat: only define variable if it is needed
G-Rath 644d23b
feat: regenerate rules
G-Rath 6d92929
docs: add note to user guide
G-Rath 50fec87
fix: avoid unneeded blank line
G-Rath 6f57445
chore: add changeset entry
G-Rath 844d3fc
revert: don't use an env variable
G-Rath b835cda
feat: generate new error-based configs
G-Rath e77678a
docs: update documentation
G-Rath 9c56a40
Merge branch 'vuejs:master' into support-erroring
G-Rath 3e9fb11
docs: update section about flat config
G-Rath c510184
refactor: reuse existing list
G-Rath 6a09005
docs: update changelog entry
G-Rath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "eslint-plugin-vue": minor | ||
| --- | ||
|
|
||
| Use `error` instead of `warn` in configs when `VUE_ESLINT_ALWAYS_ERROR` env variable is `"true"` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| 'use strict' | ||
| const config = require('./vue2-strongly-recommended-error.js') | ||
|
|
||
| module.exports = [ | ||
| ...config, | ||
| { | ||
| name: 'vue/vue2-recommended/rules', | ||
| rules: { | ||
| 'vue/attributes-order': 'error', | ||
| 'vue/block-order': 'error', | ||
| 'vue/no-lone-template': 'error', | ||
| 'vue/no-multiple-slot-args': 'error', | ||
| 'vue/no-required-prop-with-default': 'error', | ||
| 'vue/no-v-html': 'error', | ||
| 'vue/order-in-components': 'error', | ||
| 'vue/this-in-template': 'error' | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| 'use strict' | ||
| const config = require('./vue2-essential.js') | ||
|
|
||
| module.exports = [ | ||
| ...config, | ||
| { | ||
| name: 'vue/vue2-strongly-recommended/rules', | ||
| rules: { | ||
| 'vue/attribute-hyphenation': 'error', | ||
| 'vue/component-definition-name-casing': 'error', | ||
| 'vue/first-attribute-linebreak': 'error', | ||
| 'vue/html-closing-bracket-newline': 'error', | ||
| 'vue/html-closing-bracket-spacing': 'error', | ||
| 'vue/html-end-tags': 'error', | ||
| 'vue/html-indent': 'error', | ||
| 'vue/html-quotes': 'error', | ||
| 'vue/html-self-closing': 'error', | ||
| 'vue/max-attributes-per-line': 'error', | ||
| 'vue/multiline-html-element-content-newline': 'error', | ||
| 'vue/mustache-interpolation-spacing': 'error', | ||
| 'vue/no-multi-spaces': 'error', | ||
| 'vue/no-spaces-around-equal-signs-in-attribute': 'error', | ||
| 'vue/no-template-shadow': 'error', | ||
| 'vue/one-component-per-file': 'error', | ||
| 'vue/prop-name-casing': 'error', | ||
| 'vue/require-default-prop': 'error', | ||
| 'vue/require-prop-types': 'error', | ||
| 'vue/singleline-html-element-content-newline': 'error', | ||
| 'vue/v-bind-style': 'error', | ||
| 'vue/v-on-style': 'error', | ||
| 'vue/v-slot-style': 'error' | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| 'use strict' | ||
| const config = require('./vue3-strongly-recommended-error.js') | ||
|
|
||
| module.exports = [ | ||
| ...config, | ||
| { | ||
| name: 'vue/recommended/rules', | ||
| rules: { | ||
| 'vue/attributes-order': 'error', | ||
| 'vue/block-order': 'error', | ||
| 'vue/no-lone-template': 'error', | ||
| 'vue/no-multiple-slot-args': 'error', | ||
| 'vue/no-required-prop-with-default': 'error', | ||
| 'vue/no-v-html': 'error', | ||
| 'vue/order-in-components': 'error', | ||
| 'vue/this-in-template': 'error' | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| 'use strict' | ||
| const config = require('./vue3-essential.js') | ||
|
|
||
| module.exports = [ | ||
| ...config, | ||
| { | ||
| name: 'vue/strongly-recommended/rules', | ||
| rules: { | ||
| 'vue/attribute-hyphenation': 'error', | ||
| 'vue/component-definition-name-casing': 'error', | ||
| 'vue/first-attribute-linebreak': 'error', | ||
| 'vue/html-closing-bracket-newline': 'error', | ||
| 'vue/html-closing-bracket-spacing': 'error', | ||
| 'vue/html-end-tags': 'error', | ||
| 'vue/html-indent': 'error', | ||
| 'vue/html-quotes': 'error', | ||
| 'vue/html-self-closing': 'error', | ||
| 'vue/max-attributes-per-line': 'error', | ||
| 'vue/multiline-html-element-content-newline': 'error', | ||
| 'vue/mustache-interpolation-spacing': 'error', | ||
| 'vue/no-multi-spaces': 'error', | ||
| 'vue/no-spaces-around-equal-signs-in-attribute': 'error', | ||
| 'vue/no-template-shadow': 'error', | ||
| 'vue/one-component-per-file': 'error', | ||
| 'vue/prop-name-casing': 'error', | ||
| 'vue/require-default-prop': 'error', | ||
| 'vue/require-explicit-emits': 'error', | ||
| 'vue/require-prop-types': 'error', | ||
| 'vue/singleline-html-element-content-newline': 'error', | ||
| 'vue/v-bind-style': 'error', | ||
| 'vue/v-on-event-hyphenation': [ | ||
| 'error', | ||
| 'always', | ||
| { | ||
| autofix: true | ||
| } | ||
| ], | ||
| 'vue/v-on-style': 'error', | ||
| 'vue/v-slot-style': 'error' | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| module.exports = { | ||
| extends: require.resolve('./vue2-strongly-recommended-error'), | ||
| rules: { | ||
| 'vue/attributes-order': 'error', | ||
| 'vue/block-order': 'error', | ||
| 'vue/no-lone-template': 'error', | ||
| 'vue/no-multiple-slot-args': 'error', | ||
| 'vue/no-required-prop-with-default': 'error', | ||
| 'vue/no-v-html': 'error', | ||
| 'vue/order-in-components': 'error', | ||
| 'vue/this-in-template': 'error' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| module.exports = { | ||
| extends: require.resolve('./vue2-essential'), | ||
| rules: { | ||
| 'vue/attribute-hyphenation': 'error', | ||
| 'vue/component-definition-name-casing': 'error', | ||
| 'vue/first-attribute-linebreak': 'error', | ||
| 'vue/html-closing-bracket-newline': 'error', | ||
| 'vue/html-closing-bracket-spacing': 'error', | ||
| 'vue/html-end-tags': 'error', | ||
| 'vue/html-indent': 'error', | ||
| 'vue/html-quotes': 'error', | ||
| 'vue/html-self-closing': 'error', | ||
| 'vue/max-attributes-per-line': 'error', | ||
| 'vue/multiline-html-element-content-newline': 'error', | ||
| 'vue/mustache-interpolation-spacing': 'error', | ||
| 'vue/no-multi-spaces': 'error', | ||
| 'vue/no-spaces-around-equal-signs-in-attribute': 'error', | ||
| 'vue/no-template-shadow': 'error', | ||
| 'vue/one-component-per-file': 'error', | ||
| 'vue/prop-name-casing': 'error', | ||
| 'vue/require-default-prop': 'error', | ||
| 'vue/require-prop-types': 'error', | ||
| 'vue/singleline-html-element-content-newline': 'error', | ||
| 'vue/v-bind-style': 'error', | ||
| 'vue/v-on-style': 'error', | ||
| 'vue/v-slot-style': 'error' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| module.exports = { | ||
| extends: require.resolve('./vue3-strongly-recommended-error'), | ||
| rules: { | ||
| 'vue/attributes-order': 'error', | ||
| 'vue/block-order': 'error', | ||
| 'vue/no-lone-template': 'error', | ||
| 'vue/no-multiple-slot-args': 'error', | ||
| 'vue/no-required-prop-with-default': 'error', | ||
| 'vue/no-v-html': 'error', | ||
| 'vue/order-in-components': 'error', | ||
| 'vue/this-in-template': 'error' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * IMPORTANT! | ||
| * This file has been automatically generated, | ||
| * in order to update its content execute "npm run update" | ||
| */ | ||
| module.exports = { | ||
| extends: require.resolve('./vue3-essential'), | ||
| rules: { | ||
| 'vue/attribute-hyphenation': 'error', | ||
| 'vue/component-definition-name-casing': 'error', | ||
| 'vue/first-attribute-linebreak': 'error', | ||
| 'vue/html-closing-bracket-newline': 'error', | ||
| 'vue/html-closing-bracket-spacing': 'error', | ||
| 'vue/html-end-tags': 'error', | ||
| 'vue/html-indent': 'error', | ||
| 'vue/html-quotes': 'error', | ||
| 'vue/html-self-closing': 'error', | ||
| 'vue/max-attributes-per-line': 'error', | ||
| 'vue/multiline-html-element-content-newline': 'error', | ||
| 'vue/mustache-interpolation-spacing': 'error', | ||
| 'vue/no-multi-spaces': 'error', | ||
| 'vue/no-spaces-around-equal-signs-in-attribute': 'error', | ||
| 'vue/no-template-shadow': 'error', | ||
| 'vue/one-component-per-file': 'error', | ||
| 'vue/prop-name-casing': 'error', | ||
| 'vue/require-default-prop': 'error', | ||
| 'vue/require-explicit-emits': 'error', | ||
| 'vue/require-prop-types': 'error', | ||
| 'vue/singleline-html-element-content-newline': 'error', | ||
| 'vue/v-bind-style': 'error', | ||
| 'vue/v-on-event-hyphenation': [ | ||
| 'error', | ||
| 'always', | ||
| { | ||
| autofix: true | ||
| } | ||
| ], | ||
| 'vue/v-on-style': 'error', | ||
| 'vue/v-slot-style': 'error' | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.