sfTimePicker: Apply maximum in the second and millisecond column #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the Issue
In sfTimePicker add support to reflect the maximum seconds when a MaximumTime is set that also limits the seconds. For instance the MaximumTime is 4 minutes and 15 seconds, then when selecting 4 minutes the second column would display all seconds from 0 to 59. This should be limited to the actual maximum of seconds which in our example is 15 seconds. This also applies to MilliSeconds.
Description of Change
This PR updates the seconds and milliseconds column to refelect the correct maximum.
Issues Fixed
Fixes #299
Screenshots
Before:
After: