-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add constants/float16/phi
#9001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float16/phi
#9001
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
|
||
| ## Notes | ||
|
|
||
| The golden ratio `φ` is defined as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is our convention to display mathematical formulas in a <section class="intro"> at the top of the README and not inside the notes. See float32/phi and float64/phi for reference.
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Looks very good; one request with respect to updating the README.md.
|
Thanks for the feedback @Planeshifter !! |
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves none
Description
This pull request:
constants/float16/phi(Golden Ratio)Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers