CLI: Make all paths absolute #4107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Dec 3, 2025
jamie-osec
force-pushed
the
path-canonicalize
branch
from
ce388da to
710db70
Compare
swaroop-osec
reviewed
Dec 4, 2025
swaroop-osec
requested changes
Dec 4, 2025
Collaborator
Author
|
@swaroop-osec What do you think about merging this PR as-is, as it fixes the motivating issue, and addressing the other issue in a followup? I have some ideas to eliminate these problems but they'll require some more extensive refactoring |
jamie-osec
force-pushed
the
path-canonicalize
branch
from
710db70 to
10abcc9
Compare
Collaborator
Sounds good. Please address the failed tests |
jamie-osec
force-pushed
the
path-canonicalize
branch
from
10abcc9 to
cc886e9
Compare
swaroop-osec
approved these changes
Dec 4, 2025
Co-authored-by: hasip-timurtas <hasip.timurtas@gmail.com>
jamie-osec
force-pushed
the
path-canonicalize
branch
from
cc886e9 to
b964497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2993
The root cause of the above issue is that we switch directories when running all commands, thus leaving relative paths incorrect.
This PR introduces a new trait (and corresponding derive macro)
AbsolutePathfor making paths in CLI arguments absolute. This is then used inanchor_cli::entryto prepare arguments for use.As an additional cleanup, all path arguments have been converted to
PathBuf(rather thanString).