Refactor function names of rustc_ast_lowering
#150122
Open
+113
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Dec 18, 2025
| let super_ = l.super_.map(|span| self.lower_span(span)); | ||
| let ty = l.ty.as_ref().map(|t| { | ||
| self.lower_ty(t, self.impl_trait_in_bindings_ctxt(ImplTraitPosition::Variable)) | ||
| self.lower_ty_and_intern( |
Contributor
There was a problem hiding this comment.
actually, self.lower_ty_and_alloc might be better, we're not really interning here
Contributor
Author
There was a problem hiding this comment.
Oh, I understand. lower_anon_const_to_const_arg_and_alloc was also reflected
lcnr
added
S-blocked
reddevilmidzy
force-pushed
the
refactor
branch
from
7c13df6 to
5d67210
Compare
rustbot
added
the
A-LLVM
This comment has been minimized.
This comment has been minimized.
`lower_anon_const_to_const_arg_direct` to `lower_anon_const_to_const_arg_and_alloc` and `lower_anon_const_to_const_arg`
reddevilmidzy
force-pushed
the
refactor
branch
from
5d67210 to
5e669d8
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot label -A-LLVM |
rustbot
removed
the
A-LLVM
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #150062
I'll rebase after #149114 is merged.
Would it be better to change
lower_const_path_to_const_arg→lower_const_path_to_const_arg_and_intern,lower_array_length_to_const_arg→lower_array_length_to_const_arg_and_intern?r? @lcnr