Skip to content

feat: add efiapi support for loongarch64 #149879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZR233 wants to merge 1 commit into from
+6 −1
Closed

feat: add efiapi support for loongarch64 #149879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/rustc_target/src/spec/abi_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ impl AbiMap {
Arch::RiscV32 | Arch::RiscV64 => ArchKind::Riscv,
Arch::X86 => ArchKind::X86,
Arch::X86_64 => ArchKind::X86_64,
Arch::LoongArch64 => ArchKind::LoongArch64,
_ => ArchKind::Other,
};

Expand Down Expand Up @@ -108,7 +109,10 @@ impl AbiMap {

(ExternAbi::EfiApi, ArchKind::Arm(..)) => CanonAbi::Arm(ArmCall::Aapcs),
(ExternAbi::EfiApi, ArchKind::X86_64) => CanonAbi::X86(X86Call::Win64),
(ExternAbi::EfiApi, ArchKind::Aarch64 | ArchKind::Riscv | ArchKind::X86) => CanonAbi::C,
(
ExternAbi::EfiApi,
ArchKind::Aarch64 | ArchKind::Riscv | ArchKind::X86 | ArchKind::LoongArch64,
Copy link
Contributor

@madsmtm madsmtm Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only LoongArch64? Isn't LoongArch32 the same?

) => CanonAbi::C,
(ExternAbi::EfiApi, _) => return AbiMapping::Invalid,

/* arm */
Expand Down Expand Up @@ -201,6 +205,7 @@ enum ArchKind {
Riscv,
X86,
X86_64,
LoongArch64,
/// Architectures which don't need other considerations for ABI lowering
Other,
}
Copy link
Contributor

@madsmtm madsmtm Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should support be added in InlineAsmClobberAbi::parse as well?

Copy link
Contributor

@madsmtm madsmtm Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that was intentionally not done in #111499, so I'm unsure here?

Copy link
Contributor

@madsmtm madsmtm Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference should be updated as well:

https://doc.rust-lang.org/reference/items/external-blocks.html#r-items.extern.abi.efiapi

Expand Down
Loading