Fix restrictions of or-patterns #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
A small discrepancy in the definition of `or-patterns` was discovered during the `rust-lang/fls` meeting on 2025-12-12 involving Eric Huss and TC - `or-patterns` must not be used in function and closure **parameters**, as opposed to function and closure arguments as stated in the text. Function and closure parameters are the constructs carrying `PatternNoTopAlt`s.
kirtchev-adacore
force-pushed
the
pr/fix-or-pattern-definition
branch
from
238402c to
ade7a62
Compare
kirtchev-adacore
changed the title
rustbot
removed
the
S-waiting-on-review
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 16, 2025
Update books ## rust-lang/nomicon 1 commits in 9fe8fa599ad228dda74f240cc32b54bc5c1aa3e6..5b3a9d084cbc64e54da87e3eec7c7faae0e48ba9 2025-12-12 12:24:05 UTC to 2025-12-12 12:24:05 UTC - Update method lookup link in dot-operator.md (rust-lang/nomicon#513) ## rust-lang/reference 4 commits in 50c5de90487b68d429a30cc9466dc8f5b410128f..ec78de0ffe2f8344bd0e222b17ac7a7d32dc7a26 2025-12-15 16:17:43 UTC to 2025-12-15 16:15:06 UTC - tokens: clarify in escape tables that digits are hex (rust-lang/reference#2105) - tokens: remove misplaced ".token." within a word (rust-lang/reference#2106) - macros-by-example: add space in `macro.decl.repetition.fragment` example (rust-lang/reference#2107) - Fix restrictions of or-patterns (rust-lang/reference#2108)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 16, 2025
Update books ## rust-lang/nomicon 1 commits in 9fe8fa599ad228dda74f240cc32b54bc5c1aa3e6..5b3a9d084cbc64e54da87e3eec7c7faae0e48ba9 2025-12-12 12:24:05 UTC to 2025-12-12 12:24:05 UTC - Update method lookup link in dot-operator.md (rust-lang/nomicon#513) ## rust-lang/reference 4 commits in 50c5de90487b68d429a30cc9466dc8f5b410128f..ec78de0ffe2f8344bd0e222b17ac7a7d32dc7a26 2025-12-15 16:17:43 UTC to 2025-12-15 16:15:06 UTC - tokens: clarify in escape tables that digits are hex (rust-lang/reference#2105) - tokens: remove misplaced ".token." within a word (rust-lang/reference#2106) - macros-by-example: add space in `macro.decl.repetition.fragment` example (rust-lang/reference#2107) - Fix restrictions of or-patterns (rust-lang/reference#2108)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 16, 2025
Rollup merge of #150029 - rustbot:docs-update, r=ehuss Update books ## rust-lang/nomicon 1 commits in 9fe8fa599ad228dda74f240cc32b54bc5c1aa3e6..5b3a9d084cbc64e54da87e3eec7c7faae0e48ba9 2025-12-12 12:24:05 UTC to 2025-12-12 12:24:05 UTC - Update method lookup link in dot-operator.md (rust-lang/nomicon#513) ## rust-lang/reference 4 commits in 50c5de90487b68d429a30cc9466dc8f5b410128f..ec78de0ffe2f8344bd0e222b17ac7a7d32dc7a26 2025-12-15 16:17:43 UTC to 2025-12-15 16:15:06 UTC - tokens: clarify in escape tables that digits are hex (rust-lang/reference#2105) - tokens: remove misplaced ".token." within a word (rust-lang/reference#2106) - macros-by-example: add space in `macro.decl.repetition.fragment` example (rust-lang/reference#2107) - Fix restrictions of or-patterns (rust-lang/reference#2108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small discrepancy in the definition of
or-patternswas discovered during therust-lang/flsmeeting on 2025-12-12 involving Eric Huss and TC -or-patternsmust not be used in function and closure parameters, as opposed to function and closure arguments as stated in the text. Function and closure parameters are the constructs carryingPatternNoTopAlts.