Expand identifier set #3499
Open
Expand identifier set #3499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, path, processing information for a study
Member
|
Thank you @wasade, this looks great. I completely understand why the code creates the unique ids on demand but my concern is that this might create an extra layer of complexity vs. adding to all from the start. In specific, my concern is that the order of the unique ids has no actual relationship on artifact/prep/study-id, which might be OK. Thus, just confirming that this is desirable before merging. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3498
This pull request introduces sample_idx, prep_sample_idx and artifact_sample_idx values. These are Qiita-wide unique and provide an integer identifier for use within study, prep and artifact respectively.