add analysis id to validate parameters #3497
Merged
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspatel
approved these changes
Dec 15, 2025
Collaborator
lucaspatel
left a comment
lucaspatel
left a comment
There was a problem hiding this comment.
Seems like a minor reorganization, LGTM
qiita_db/processing_job.py
Outdated
| ) | ||
| if len(data_type) != 1: | ||
| raise ValueError( | ||
| f"Not valida parents data_types: {data_type}" |
lucaspatel
approved these changes
Dec 16, 2025
Collaborator
lucaspatel
left a comment
lucaspatel
left a comment
There was a problem hiding this comment.
Looks fine to me, though be mindful of security concerns here
| samples : dictionary of lists | ||
| samples and the artifact id they come from in form | ||
| {artifact_id: [sample1, sample2, ...], ...} | ||
| overwrite_lock : bool, optional |
Collaborator
There was a problem hiding this comment.
I'm sure you have good reason for this, but this seems potentially unsafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.