Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

ovcharenko-di · 2025-12-17T10:37:14Z

В этом PR:

полноценное тестирование на GA (по аналогии с gitsync-plugins)
- на двух версиях платформы 1С
- тестирование на Windows и Linux
исправление падающих тестов
отключение сборки exe и всего, что с этим связано
обновление конфигов для VS Code
исправление опечаток, удаление лишнего
удаление Jenkinsfile и конфига для Travis-CI за ненадобностью

@oscript-library/Collaborators - пожалуйста, проверьте изменения и прокомментируйте их

This reverts commit 36cca7e.

github-actions · 2025-12-17T11:48:28Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:48:31Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: windows-latest. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:50:16Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.24.1691. Версия OneScript: 1.9.2

github-actions · 2025-12-17T11:50:28Z

	Tests	Passed ✅	Skipped	Failed
Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2	428 ran	428 passed	0 skipped	0 failed

View Результаты тестов. ОС: ubuntu-22.04. Версия 1С: 8.3.21.1624. Версия OneScript: 1.9.2

Copilot

Pull request overview

This PR updates gitsync to version 3.7.0 with plugins v2.0.0, introducing comprehensive GitHub Actions-based testing infrastructure while removing legacy CI/CD configurations (Travis CI and Jenkins). The changes modernize the testing approach, fix various spelling errors, and update all dependencies to newer versions.

Key Changes:

Implemented full GitHub Actions testing workflow with coverage collection and multi-platform support (Windows/Linux, multiple 1C platform versions)
Updated all package dependencies to newer versions (e.g., logos 1.7.1, v8runner 1.12.0, gitrunner 1.8.0)
Fixed numerous spelling errors throughout feature files and step definitions (e.g., "тестовой" → "тестовый", "ищю" → "ищу")
Refactored test execution to use centralized build/reports directory structure with improved coverage handling

Reviewed changes

Copilot reviewed 46 out of 47 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
travis-ci.sh	Removed legacy Travis CI build script
Jenkinsfile	Removed legacy Jenkins pipeline configuration
packagedef	Updated version to 3.7.0 and upgraded all dependency versions
build_packagedef	Updated version to 3.7.0 and environment version to 1.9.2
tasks/test.os	Major refactoring: added coverage parameter support, centralized report outputs to build/reports, improved feature execution logic
tasks/coverage.os	Added platform-specific encoding handling and reorganized coverage file structure
tasks/make.os	Commented out EXE build functionality and removed commented debug code
tasks/build.os	Removed commented-out code and debug statements
tasks/get-plugins.os	Changed repository from khorevaa to oscript-library, renamed parameters from branch to commit pointer
tasks/oscript.cfg	Changed lib.system to lib.additional for module path configuration
tests/fixtures/ext.yaml	Fixed typo: "extention" → "extension"
.vscode/tasks.json	Modernized to VS Code 2.0.0 task format with proper type, label, and presentation properties
.vscode/launch.json	Removed debugPort and protocol fields from launch configuration
.gitignore	Reorganized ignore patterns, added build/ directory
.gitattributes	Added line ending rules for cross-platform compatibility
.bsl-language-server.json	New BSL Language Server configuration file
.github/workflows/qa.yml	Changed test command from "opm run coverage" to direct oscript execution
.github/CONTRIBUTING.md	Improved formatting, updated instructions, and refreshed last update date
features/opm/opm-build.feature	Fixed typo: "установку" → "установки"
features/core/sync.core.feature	Fixed typo: "тестовой" → "тестовый", changed VERSION value from 0 to 7
features/core/sync.batch.feature	Fixed typo: "тестовой" → "тестовый", removed commented-out test code
features/core/step_definitions/sync.batch.os	Updated procedure names to match corrected spelling
features/core/step_definitions/shared.os	Fixed spelling in comments and procedure names, added new step for git author setup, removed commented code
features/core/step_definitions/check.core.os	Updated step names in list to match corrected capitalization
features/core/check.core.feature	Fixed capitalization in step names
features/cmd/v8path.feature	Fixed typo: "ищю" → "ищу", changed VERSION value from 0 to 7
features/cmd/sync.feature	Fixed typo: "тестовой" → "тестовый", changed VERSION value from 0 to 7
features/cmd/step_definitions/v8path.os	Updated procedure name to match corrected spelling
features/cmd/step_definitions/sync.core.os	Removed extra blank lines
features/cmd/step_definitions/shared.os	Fixed spelling in comments and procedure names, added new step for git author setup
features/cmd/step_definitions/init.os	Removed extra blank lines
features/cmd/step_definitions/extension.os	Added BSL diagnostic suppressions, improved comment formatting
features/cmd/step_definitions/all.os	Fixed spelling in comment and procedure name, removed unused step
features/cmd/setversion.feature	Fixed typo and whitespace, added git author setup step
features/cmd/ibconnection.feature	Fixed typo, changed VERSION value from 0 to 7, added git author setup step
features/cmd/extention.feature	Fixed typo, changed VERSION value from 0 to 4
features/cmd/clone.feature	Added git author setup step, fixed trailing whitespace
features/cmd/all.feature	Fixed spelling, improved table alignment and formatting

Comments suppressed due to low confidence (1)

travis-ci.sh:1

В CI-скрипте ранее использовалась команда наподобие curl http://oscript.io/downloads/$OSCRIPT_VERSION/deb для загрузки и установки пакета через dpkg -i, что позволяло атакующему с доступом к сети (MITM) подменить содержимое пакета и выполнить произвольный код в среде сборки. Для подобных установок необходимо использовать как минимум HTTPS-URL и, по возможности, проверку подписи или хэша загружаемого артефакта. Текущий PR удаляет этот скрипт и тем самым устраняет уязвимость; при восстановлении аналогичной логики важно использовать защищённый канал и проверку целостности.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T14:34:34Z

tasks/get-plugins.os

+Процедура ПолезнаяРабота(УказательКоммита)

-	URLРепозитория = "https://github.com/khorevaa/gitsync-plugins.git";
+	URLРепозитория = "https://github.com/oscript-library/gitsync-plugins.git";


The URL for the plugins repository has been changed from "khorevaa/gitsync-plugins" to "oscript-library/gitsync-plugins". Please verify that this repository exists and is accessible at the new location, as this change could break the plugin installation process if the repository doesn't exist or requires different authentication.

Copilot · 2025-12-17T14:34:34Z

tasks/test.os

+Если Не ФичиПрошли Тогда
 	ВызватьИсключение "Тестирование завершилось неудачно!";
-Иначе
-	Сообщить(СтрШаблон("Результат прогона тестов <%1>
-	|", ТестыПрошли));
-КонецЕсли;
+КонецЕсли;


The condition "Если Не ФичиПрошли Тогда" only checks if features passed but ignores the result of unit tests stored in "ТестыПрошли". This means unit test failures will not cause the overall test execution to fail. The original logic "Если Не ТестыПрошли Или Не ФичиПрошли Тогда" correctly checked both conditions.

Copilot · 2025-12-17T14:34:34Z

tasks/test.os

+ТекКаталог = ТекущийКаталог();
+КаталогФайловПокрытия = "";

-Если АргументыКоманднойСтроки.Количество() = 0 Тогда
-	ТолькоЮнитТесты = Ложь;
-Иначе
-	ТолькоЮнитТесты = Булево(АргументыКоманднойСтроки[0]);
-КонецЕсли;
+Для Каждого Элемент Из АргументыКоманднойСтроки Цикл
+	Если Элемент = "coverage" Тогда
+
+		КаталогФайловПокрытия = ОбъединитьПути(ТекущийКаталог(), ".", ИмяКаталогаФайловПокрытия);
+		ФС.ОбеспечитьПустойКаталог(КаталогФайловПокрытия);

-// Попытка
-// 	ТестыПрошли = ПрогнатьТесты();
+		Прервать;
+	КонецЕсли;
+КонецЦикла;

-// Исключение
-// 	ТестыПрошли = Ложь;
-// 	Сообщить(СтрШаблон("Тесты через 1testrunner выполнены неудачно
-// 	|%1", ПодробноеПредставлениеОшибки(ИнформацияОбОшибке())));
-// КонецПопытки;
+УстановитьТекущийКаталог(ТекКаталог);


The variable "ТекКаталог" is saved at line 244 but never used afterwards. The code sets the current directory back using "УстановитьТекущийКаталог(ТекКаталог)" at line 257, but there's no code between lines 244-257 that changes the current directory, making this operation unnecessary.

Copilot · 2025-12-17T14:34:35Z

.vscode/launch.json

            "name": "Отладка 1Script",
-            "type": "oscript",
            "request": "launch",
            "program": "${file}",
            "args": [],
            "cwd": "${workspaceRoot}",
            "runtimeExecutable": "/usr/bin/oscript",
-            "debugPort": 2801,
-            "protocol": "internal"
        }


The "type" field has been removed from the launch configuration, but it's a required field for VS Code launch configurations. Without it, the debugger won't know which debug adapter to use. The original value "oscript" should be retained, or if debugging is no longer supported, the entire configuration should be removed or documented as non-functional.

Copilot · 2025-12-17T14:34:35Z

features/core/step_definitions/check.core.os


 //ТестовыйПлагин реализует ИнтерфейсаПлагинов
-Процедура ТестовыйплагинРеализуетИнтерфейсаплагинов() Экспорт
+Процедура ТестовыйплагинРеализуетИнтерфейсплагинов() Экспорт


The procedure name "ТестовыйплагинРеализуетИнтерфейсплагинов" doesn't match the capitalization in the feature file which expects "ТестовыйПлагинРеализуетИнтерфейсПлагинов" (with capital letters in "Плагин" and "Плагинов"). This mismatch will cause BDD step matching to fail at runtime. The procedure name should use proper camel case: "ТестовыйПлагинРеализуетИнтерфейсПлагинов".

Copilot · 2025-12-17T14:34:35Z

tasks/test.os

+Сообщить(СтрШаблон("Результат прогона основных фич <%1>
+|", ФичиПрошли));


The message output at line 279 says "Результат прогона основных фич" (Result of running main features) but this doesn't accurately describe what's being checked. The variable "ФичиПрошли" represents the result of ALL features (core, cmd, exe, opm), not just "main" features. Consider using "Результат прогона всех фич" (Result of running all features) for clarity.

Copilot · 2025-12-17T14:34:36Z

tasks/get-plugins.os


 Если АргументыКоманднойСтроки.Количество() = 0 Тогда
-	ИмяВетки = "master";
+	УказательКоммита = "master";


The default branch name is hardcoded as "master". Consider using "main" as the default branch name instead, as this is now the GitHub standard and many repositories have migrated from "master" to "main". This could cause failures when trying to fetch from repositories that use "main" as their default branch.

Copilot · 2025-12-17T14:34:36Z

tasks/coverage.os

+Если НЕ ЭтоWindows Тогда
+	Команда.ДобавитьПараметр("-encoding=utf-8");
 КонецЕсли;


The encoding parameter is only added for non-Windows systems, but the encoding issue can occur on Windows as well depending on the console configuration. The "-encoding=utf-8" parameter should be added unconditionally to ensure consistent behavior across all platforms, especially since the codebase contains Cyrillic characters.

Copilot · 2025-12-17T14:34:36Z

.vscode/tasks.json

        {
-            "taskName": "Exec feature",
+            "label": "Exec feature",
+            "type": "bsl",


The task type is set to "bsl" which is not a standard VS Code task type. Valid task types are "shell", "process", or task types provided by extensions. Unless there's a specific VSCode extension that provides the "bsl" task type, this should be "shell" to match the other tasks in this file.

Copilot · 2025-12-17T14:34:36Z

features/core/step_definitions/check.core.os

-//МенеджераПодписок реализует ИнтерфейсаПлагинов
-Процедура МенеджераподписокРеализуетИнтерфейсаплагинов() Экспорт
+//МенеджерПодписок реализует ИнтерфейсПлагинов
+Процедура МенеджерподписокРеализуетИнтерфейсплагинов() Экспорт


The procedure name "МенеджерподписокРеализуетИнтерфейсплагинов" doesn't match the capitalization in the feature file which expects "МенеджерПодписокРеализуетИнтерфейсПлагинов" (with capital letters in "Подписок" and "Плагинов"). This mismatch will cause BDD step matching to fail at runtime. The procedure name should use proper camel case: "МенеджерПодписокРеализуетИнтерфейсПлагинов".

nixel2007 · 2025-12-17T15:26:06Z

LGTM!

ovcharenko-di and others added 29 commits December 17, 2025 14:41

upd tests

fd11bbd

fix testing

8152b7a

add gitkeep

afb58ec

rm install-gitsync, fix test command

ce8acd5

Revert "add gitkeep"

f32c97c

This reverts commit 36cca7e.

upd tasks and debug

293da61

fix typo

4655e17

fix typo

cdbf932

speed up tests

aceae60

fix typo

f1eba55

add bsl language config

bd8dba6

upd gitignore

f587c66

rip jenkins

146a023

rip travis-ci

b9bdb8d

bump deps and version

a759648

upd guide

fa7877c

upd testing workflow

aff0bc3

fix

1164013

fix steps, features and typos

b840a4e

switch to local

616a0e4

implement test

5cb1eb4

upd coverage (from gitsync-plugins)

4f9ca82

cleanup

0e69c97

fix naming

f2af68e

rm exe, cleanup

cbc33b9

switch to full paths, fix logging

13f3953

take plugins from master@gitsync-plugins

5c1d1e0

bump

4206eb4

add gitattributes

cf4fc7a

ovcharenko-di force-pushed the fix/testing branch from 68117f8 to cf4fc7a Compare December 17, 2025 11:42

fix command

9498f21

ovcharenko-di requested review from Copilot and nixel2007 December 17, 2025 14:27

Copilot started reviewing on behalf of ovcharenko-di December 17, 2025 14:28 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

nixel2007 approved these changes Dec 17, 2025

View reviewed changes

		Сообщить(СтрШаблон("Результат прогона основных фич <%1>
		\|", ФичиПрошли));

Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

Are you sure you want to change the base?

Версия 3.7.0 с плагинами v2.0.0, тестирование на GA #340

Uh oh!

Conversation

ovcharenko-di commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nixel2007 commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading