Add session customization params to Runner options #2196
+214
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrieval from sessions and include new test.
seratch
requested changes
Dec 17, 2025
Member
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks for sending this pull request! Adding the limit option is reasonable, but we'd like to make the new option to be open to future enhancement. So can you create new SessionSettings class (in the same way with ModelSettings) and move the liimt parameter as the first and only property in it?
seratch
changed the title
seratch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add
session_limitparameter to control conversation history retrieval from sessions and include new test.