fix mac func dependencies GHA workflow (#968)

* fix mac func dependencies GHA workflow

* return False on invalid split

Author: ben-c-at-moz

.github/workflows/functional-test-beta.yml

@@ -56,7 +56,9 @@ jobs:
     secrets: inherit
 
   Run-Mac-Functional:
-    needs: Check-Beta-Version
+    needs:
+      - Check-Beta-Version
+      - Get-Functional-Split
     if: ${{ needs.Check-Beta-Version.outputs.mac_reportable == 'True' }}
     uses: ./.github/workflows/main.yml
     with:

modules/testrail_integration.py

@@ -275,6 +275,17 @@ def reportable(platform_to_test=None):
         return covered_mappings < expected_mappings
     else:
         logging.warning(f"Getting reportability for STARfox in {platform}...")
+        if not os.environ.get("STARFOX_SPLIT"):
+            logging.warning("No split selected")
+            return False
+        manifest = TestKey(TEST_KEY_LOCATION)
+        expected_suites = manifest.get_valid_suites_in_split(
+            os.environ["STARFOX_SPLIT"], suite_numbers=True
+        )
+        if not expected_suites:
+            logging.warning("This split is empty, not running or reporting.")
+            return False
+
         covered_suites = []
         for entry in plan_entries:
             for run_ in entry.get("runs"):
@@ -291,17 +302,6 @@ def reportable(platform_to_test=None):
                 f"Suite coverage found for Suite IDs: {', '.join(covered_suites)}"
             )
 
-        if not os.environ.get("STARFOX_SPLIT"):
-            logging.warning("No split selected")
-            return False
-        manifest = TestKey(TEST_KEY_LOCATION)
-        expected_suites = manifest.get_valid_suites_in_split(
-            os.environ["STARFOX_SPLIT"], suite_numbers=True
-        )
-        if not expected_suites:
-            logging.warning("This split is empty, not running or reporting.")
-            return False
-
         uncovered_suites = list(set(expected_suites) - set(covered_suites))
         if len(uncovered_suites):
             suite_names = []