write test_set input directly to STARFOX_SPLIT (#967)

Author: ben-c-at-moz

.github/workflows/main.yml

@@ -38,7 +38,7 @@ on:
         type: string
 env:
   FX_CHANNEL: ${{ inputs.channel }}
-  TEST_SET: ${{ inputs.test_set }}
+  STARFOX_SPLIT: ${{ inputs.test_set }}
   TESTRAIL_BASE_URL: ${{ secrets.TESTRAIL_BASE_URL }}
   TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }}
   TESTRAIL_USERNAME: ${{ secrets.TESTRAIL_USERNAME }}
@@ -65,11 +65,6 @@ jobs:
         run: |
           echo "TESTRAIL_REPORT=true" | Out-File -FilePath .env -Encoding utf8 -Append -Force
           Write-Host "Running report for most recent Beta on Windows"
-      - name: Select Test Set
-        if: ${{ inputs.test_set != null }}
-        run: |
-          echo "STARFOX_SPLIT=$TEST_SET" | Out-File -FilePath .env -Encoding utf8 -Append -Force
-        shell: pwsh
       - name: Install dependencies
         run: |
           mkdir -p artifacts;
@@ -168,9 +163,6 @@ jobs:
         run: |
           echo "TESTRAIL_REPORT='true'" >> "$GITHUB_ENV";
           echo "Running report for most recent Beta on MacOS";
-      - name: Select Test Set
-        if: ${{ inputs.test_set != null }}
-        run: echo "STARFOX_SPLIT=$TEST_SET" >> .env
       - name: Set Environment (Manual)
         if: ${{ inputs.mac_installer_link }}
         run: |

modules/testrail_integration.py

@@ -292,7 +292,8 @@ def reportable(platform_to_test=None):
             )
 
         if not os.environ.get("STARFOX_SPLIT"):
-            sys.exit("No split selected")
+            logging.warning("No split selected")
+            return False
         manifest = TestKey(TEST_KEY_LOCATION)
         expected_suites = manifest.get_valid_suites_in_split(
             os.environ["STARFOX_SPLIT"], suite_numbers=True