Skip to content

Conversation

@mcgov
Copy link
Collaborator

@mcgov mcgov commented Nov 13, 2025

Gathers and checks packet drops at the end of send receive tests. Senders are allowed to drop more packets, we intentionally tune it to maximize the PPS, so some drops are expected. The rough metric in this PR is that the percentage of packets dropped should not exceed 20% on the sender and 1% on the receiver.

@mcgov mcgov force-pushed the mcgov/packet-drop branch from 9267eff to 23ef044 Compare November 13, 2025 01:13
Gathers and checks packet drops at the end of send receive tests. Senders are allowed to drop more packets, we intentionally tune it to maximize the PPS, so some drops are expected. The rough metric in this PR is that the percentage of packets dropped should not exceed 20% on the sender and 1% on the receiver.
@mcgov mcgov force-pushed the mcgov/packet-drop branch from 23ef044 to 67fcb88 Compare November 13, 2025 01:20
@paxue paxue requested review from paxue and removed request for paxue November 21, 2025 05:12
@mcgov mcgov force-pushed the mcgov/packet-drop branch 2 times, most recently from b0268c2 to df6d583 Compare December 4, 2025 20:18
@mcgov mcgov force-pushed the mcgov/packet-drop branch from df6d583 to 9234917 Compare December 4, 2025 20:24
@mcgov mcgov marked this pull request as ready for review December 4, 2025 20:33
@mcgov mcgov requested a review from LiliDeng as a code owner December 4, 2025 20:33
@LiliDeng LiliDeng requested a review from Copilot December 12, 2025 02:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds packet drop validation to DPDK send/receive tests by collecting and checking packet drop statistics at the end of test runs. The implementation introduces new regex patterns to capture packet drop and total packet counts from testpmd output, adds validation methods to ensure drop rates remain within acceptable thresholds (33% for sender, 1% for receiver), and annotates test results with receiver packet drop rates for monitoring purposes.

Key Changes:

  • Added packet drop rate validation with configurable thresholds for sender and receiver
  • Introduced new testpmd output parsing for packet drop metrics
  • Enhanced test result annotations with packet drop statistics

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
lisa/microsoft/testsuites/dpdk/dpdktestpmd.py Added regex patterns for packet drop/total metrics, implemented check_tx_packet_drops() and check_rx_packet_drops() validation methods, extended populate_performance_data() to collect drop statistics
lisa/microsoft/testsuites/dpdk/dpdkutil.py Integrated packet drop checks into verify_dpdk_send_receive() workflow, added annotate_packet_drops() helper function to record receiver drop rates in test results

@LiliDeng
Copy link
Collaborator

LiliDeng commented Dec 12, 2025

@mcgov the description 20% is inconsistent with the changed code, is it expected? Please rebase code from the latest main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants