-
Notifications
You must be signed in to change notification settings - Fork 41.9k
local-up-cluster.sh: support more recent containerd like 2.2 #135692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The kubekins image got updated from containerd 1.7 to 2.2, which broke local-up-cluster.sh in the CI because more recent containerd uses single quotation marks around strings instead of double quotation marks as before. The search/replaced with sed no longer matched, causing containerd to fail mounting overlayfs on the default /var/lib/containerd. We have to use the emptyDir host mount under /docker-graph. The fix is to relax the search term slightly so that it accepts both kinds of quotation marks.
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Dec 10 03:39:32 UTC 2025. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/sig testing |
|
/test pull-kubernetes-e2e-gce Some NFS failures (known issue, if I am not mistaken). /skip Cluster creation worked again https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/135692/pull-kubernetes-local-e2e/1998669135306821632, but there are some know test failures that prevent a fully successful run. /assign @dims @BenTheElder @upodroid I suggest we wait for code thaw, give this some soak time in master, then ask for a backport to release-1.34 and release-1.35. |
|
/approve |
|
LGTM label has been added. Git tree hash: 8c18656666c6c07f81f4f6847ee72c76cdc29c9a
|
BenTheElder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Retesting failed PR that otherwise appears ready for merge. Please help us fix flaky tests by following our Flaky Tests Guide. Prevent this bot from retesting with /retest-required |
I don't think this is a risk for code freeze but I do think it's less than ideal to have one of our test signals remain broken. This change shouldn't affect end-users, but it does affect our CI and developers, and the change is small. If the job weren't still failing for other reasons, I'd recommend landing it for sure, as-is I guess I can see waiting. Are those just flakes, or fundamentally broken tests on local-up-cluster.sh e2e? |
|
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
So you are suggesting we should ask SIG Release to include this in 1.35? It wouldn't remain broken for long (one more week) if not included. |
Yeah, at this point I could go either way, but I think it's harmless to the release (fully contained to a developer script that is not used directly for releasing and not used in production) and not fixing it makes some of our CI useless in the interim. If we merge other changes we're down signal on those, at least not anything critical. |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
The kubekins image got updated from containerd 1.7 to 2.2, which broke local-up-cluster.sh in the CI because more recent containerd uses single quotation marks around strings instead of double quotation marks as before. The search/replace with sed no longer matched, causing containerd to fail mounting overlayfs on the default /var/lib/containerd. We have to use the emptyDir host mount under /docker-graph.
The fix is to relax the search term slightly so that it accepts both kinds of quotation marks.
Which issue(s) this PR is related to:
N/A
https://testgrid.k8s.io/conformance-all#local-up-cluster,%20master%20(dev)
https://testgrid.k8s.io/sig-node-dynamic-resource-allocation#ci-dra-integration
https://testgrid.k8s.io/sig-node-dynamic-resource-allocation#ci-dra-integration-1-34
https://testgrid.k8s.io/sig-node-dynamic-resource-allocation#ci-dra-integration-1-35
Special notes for your reviewer:
See also Slack:
This needs to be backported to 1.34 and 1.35 if it doesn't make it into 1.35.0.
Does this PR introduce a user-facing change?