More work on query parameter binding stuff #11421
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
force-pushed
the
parameter-binding-redux
branch
from
1d3be1d to
257a78f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private <X> TemporalJavaType<X> forMissingPrecision(TypeConfiguration typeConfiguration) { | ||
| //noinspection unchecked,rawtypes | ||
| return (TemporalJavaType) this; | ||
| private TemporalJavaType<T> forMissingPrecision(TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
|
|
||
| protected <X> TemporalJavaType<X> forTimestampPrecision(TypeConfiguration typeConfiguration) { | ||
| protected TemporalJavaType<T> forTimestampPrecision(TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
|
|
||
| protected <X> TemporalJavaType<X> forDatePrecision(TypeConfiguration typeConfiguration) { | ||
| protected TemporalJavaType<T> forDatePrecision(TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
|
|
||
| protected <X> TemporalJavaType<X> forTimePrecision(TypeConfiguration typeConfiguration) { | ||
| protected TemporalJavaType<T> forTimePrecision(TypeConfiguration typeConfiguration) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
gavinking
force-pushed
the
parameter-binding-redux
branch
from
257a78f to
3842838
Compare
gavinking
force-pushed
the
parameter-binding-redux
branch
from
3842838 to
1bcd5cc
Compare
gavinking
force-pushed
the
parameter-binding-redux
branch
from
1bcd5cc to
343ac2a
Compare
I have no idea why it was important that two timestamp types were identical, nor do I understand why this test suddenly started failing after a rebase, but I don't think it can possibly be very important anymore
1 participant
#11417 enabled a much more complete solution
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.