HHH-19826 Add array_reverse and array_sort functions #11391
+1,649
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
beikov
requested changes
Dec 8, 2025
Member
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
This looks quite good already. I left a couple of comments.
hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/dialect/function/array/AbstractArraySortFunction.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/dialect/function/array/AbstractArraySortFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/criteria/HibernateCriteriaBuilder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/type/OracleUserDefinedTypeExporter.java
Outdated
Show resolved
Hide resolved
...te-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArraySortEmulation.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArrayReverseEmulation.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArraySortFunction.java
Outdated
Show resolved
Hide resolved
...te-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArraySortEmulation.java
Show resolved
Hide resolved
Author
|
Thanks for the guidance @beikov. |
beikov
reviewed
Dec 10, 2025
hibernate-core/src/main/java/org/hibernate/dialect/type/OracleUserDefinedTypeExporter.java
Outdated
Show resolved
Hide resolved
beikov
reviewed
Dec 10, 2025
hibernate-core/src/main/java/org/hibernate/dialect/type/OracleUserDefinedTypeExporter.java
Outdated
Show resolved
Hide resolved
beikov
requested changes
Dec 10, 2025
Member
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
Can you also please do the simplifications I proposed across all three emulations?
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
Author
beikov
reviewed
Dec 11, 2025
hibernate-core/src/main/java/org/hibernate/dialect/function/array/H2ArraySortFunction.java
Outdated
Show resolved
Hide resolved
...te-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLArraySortEmulation.java
Outdated
Show resolved
Hide resolved
Implement array_reverse() and array_sort() with PostgreSQL 18 semantics. Supports PostgreSQL, H2, HSQLDB, Oracle, and CockroachDB with native functions or SQL emulation as appropriate. Signed-off-by: Yoobin Yoon <yunyubin54@gmail.com>
Author
|
@beikov Additionally updated |
beikov
approved these changes
Dec 12, 2025
Member
|
Great job, thanks! |
Member
|
FYI, we will be merging this PR next week when we branch off for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
array_reverse()andarray_sort()HQL functions.array_reverse(array)- Returns reversed arrayarray_sort(array [, descending [, nulls_first]])- Returns sorted arrayAll database tests pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19826