Skip to content

Fix test skip mechanism to handle empty env vars #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geropl wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix test skip mechanism to handle empty env vars #21190

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df23a62
Fix test skip mechanism to handle empty env vars
geropl Dec 10, 2025
b60ed6c
[content-service] Fix outdated test expectations
geropl Dec 11, 2025
17ed34e
[dev] Drop "--ignore-scripts" for yarn, as we rely on it in a number …
geropl Dec 11, 2025
efae4dd
[dev] Use new dev-image throughout CI: dev-environment:fix-skip-if-em…
geropl Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions components/gitpod-protocol/src/util/skip-if.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
*/

/**
* Skips a Mocha TestSuite if a certain env var is not set and prints its
* Skips a Mocha TestSuite if a certain env var is not set or empty
* @param name The name of the env var the TestSuite depends on being present
*/
export function ifEnvVarNotSet(name: string): boolean {
const skip = process.env[name] === undefined;
const value = process.env[name];
const skip = value === undefined || value === "";
if (skip) {
console.log(`Skipping suite because env var '${name}' is not set`);
console.log(`Skipping suite because env var '${name}' is not set or empty`);
}
return skip;
}
Loading