feat(core): add metric drop limit with in-flight tracking #18467
+114
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track in-flight metrics when flushing and include them in the drop limit check to prevent unbounded growth when network sends are slower than metric production.
Member
|
For me, the implementation looks great thanks, you can ignore the failing "Size check" action for now. Let's wait for @chargome on this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // sendEnvelope should not throw | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| client.sendEnvelope(envelope); | ||
| client.sendEnvelope(envelope).then(() => _setInFlightCount(client, count => count - metricsCount)); |
There was a problem hiding this comment.
Bug: In-flight count leaks if sendEnvelope promise rejects
The in-flight count decrement uses .then() without a .catch() or .finally(). If sendEnvelope rejects for any reason (despite the comment saying it shouldn't throw), the callback never runs and metricsCount is never subtracted from the in-flight counter. This causes a permanent leak where the in-flight count stays artificially high, leading to future metrics being incorrectly dropped due to the inflated total. Using .finally() instead would ensure the count is always decremented regardless of promise resolution or rejection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track in-flight metrics when flushing and include them in the drop limit check to prevent unbounded growth when network sends are slower than metric production.
Closes #18080
Closes JS-1107