Skip to content

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Dec 10, 2025

(closes #18438)
(closes JS-1273)

This moves the express types as optional peerDependencies. Since we are only relying on Request and Response and nothing more, this should be a save update. In order to also test against this - I updated the the local types to v5.

The pattern of having the types as optional peerDependencies is already given for our Cloudflare SDK:

"peerDependencies": {
"@cloudflare/workers-types": "^4.x"
},
"peerDependenciesMeta": {
"@cloudflare/workers-types": {
"optional": true
}
},

@JPeer264 JPeer264 self-assigned this Dec 10, 2025
@linear
Copy link

linear bot commented Dec 10, 2025

@JPeer264 JPeer264 marked this pull request as draft December 10, 2025 09:17
@JPeer264
Copy link
Member Author

(moved to draft because I don't want this to be merged yet (see #18438 (comment)), but it can be reviewed)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,599 - 8,696 -1%
GET With Sentry 1,689 20% 1,699 -1%
GET With Sentry (error only) 6,027 70% 6,010 +0%
POST Baseline 1,182 - 1,126 +5%
POST With Sentry 573 48% 580 -1%
POST With Sentry (error only) 1,016 86% 1,050 -3%
MYSQL Baseline 3,254 - 3,339 -3%
MYSQL With Sentry 463 14% 453 +2%
MYSQL With Sentry (error only) 2,642 81% 2,684 -2%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump @types/express to v5 for @sentry/google-cloud-serverless

2 participants