feat(version): add MANUAL_VERSION, --next and --patch to version comm… #1724
Conversation
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
github-actions
bot
added
pr-status: wait-for-review
type: feature
|
@Lee-W I already ran Do you have any ideas why this happen |
| version = f"{version_scheme.minor}" | ||
| out.write(version.major) | ||
| return | ||
| if self.arguments.get("minor"): |
There was a problem hiding this comment.
I realize now that this creates problems with the (not)monotonic kind of versions (and possible non-semver). I'm not sure what to do about it.
I think for now it's fine that if you diverge too much from semver in your custom version scheme, then you won't get the full range of features.
|
There was a way to run all the pre-commits, but I don't remember how it works 😅 |
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "next_version, current_version, expected_version", |
There was a problem hiding this comment.
maybe rename next_version to next_increment?
In the user facing cli, it makes sense semantically: --next=MAJOR (give me the next major).
| assert expected_version in captured.out | ||
|
|
||
|
|
||
| def test_next_version_invalid_version(config, capsys): |
There was a problem hiding this comment.
what about having a parametrize of the combinations that should fail:
@pytest.mark.parametrize(
"args",
[
# incomplete list:
{"next"},
# ...
{"--verbose", "next"}
]
)
commitizen/commands/version.py
Outdated
| out.error("Invalid version.") | ||
| return | ||
|
|
||
| if next_str := self.arguments.get("next"): |
There was a problem hiding this comment.
what would happen here if I run cz version --project --next? I would expect that to work
There was a problem hiding this comment.
That also works.
There was a problem hiding this comment.
The behavior is the same as cz version --next=*
|
Nice to see this going forward 🎉 |
…and, remove type alias
bearomorphism
force-pushed
the
feat-next-version
branch
from
54159ff to
34fb773
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-11-0 #1724 +/- ##
==========================================
Coverage ? 97.65%
==========================================
Files ? 61
Lines ? 2643
Branches ? 0
==========================================
Hits ? 2581
Misses ? 62
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I will rebase this branch after #1726 is merged. The test failure should be resolved then. |
2 participants
…and, remove type alias
Closes #1678, #1679
Manually tested and added test cases, the result LGTM.