Skip to content

Conversation

@YazdanRa
Copy link

@YazdanRa YazdanRa commented Dec 10, 2025

Description

Upadted version unpacking in tags.py to enable support for version schemes with less than 3 components.

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

Expected Behavior

If version in pyproject.toml or cli argument is less than 3 components (e.g. 1, 1.0) we won't get ValueError: not enough values to unpack (expected 3, got N) error.

Steps to Test This Pull Request

Addded new unit tests

poetry all

Additional Context

#1704

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.88%. Comparing base (120d514) to head (7d2e857).
⚠️ Report is 885 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
+ Coverage   97.33%   97.88%   +0.55%     
==========================================
  Files          42       60      +18     
  Lines        2104     2605     +501     
==========================================
+ Hits         2048     2550     +502     
+ Misses         56       55       -1     
Flag Coverage Δ
unittests 97.88% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YazdanRa YazdanRa marked this pull request as ready for review December 10, 2025 05:11
@YazdanRa YazdanRa force-pushed the feature/single-number-version branch from 03899d1 to d5d3b5f Compare December 10, 2025 18:22
@bearomorphism
Copy link
Collaborator

As I mentioned in #1704, please publish the new version scheme as a third-party plugin.

You may either reuse this branch or create another branch to update the third-party plugin list. Thanks!

Copy link
Collaborator

@bearomorphism bearomorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

@YazdanRa YazdanRa force-pushed the feature/single-number-version branch from d5d3b5f to 5a0f6fe Compare December 12, 2025 18:31
@YazdanRa YazdanRa force-pushed the feature/single-number-version branch from 5a0f6fe to 06b5e1d Compare December 12, 2025 18:35
@YazdanRa YazdanRa force-pushed the feature/single-number-version branch from 06b5e1d to 7d2e857 Compare December 12, 2025 18:51
@YazdanRa YazdanRa changed the title feat(version-schemes): add monotonic version scheme implementation feat(tags): enable version schemes with less than 3 components Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants