-
-
Notifications
You must be signed in to change notification settings - Fork 304
feat(tags): enable version schemes with less than 3 components #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(tags): enable version schemes with less than 3 components #1705
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1705 +/- ##
==========================================
+ Coverage 97.33% 97.88% +0.55%
==========================================
Files 42 60 +18
Lines 2104 2605 +501
==========================================
+ Hits 2048 2550 +502
+ Misses 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
03899d1 to
d5d3b5f
Compare
|
As I mentioned in #1704, please publish the new version scheme as a third-party plugin. You may either reuse this branch or create another branch to update the third-party plugin list. Thanks! |
bearomorphism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
d5d3b5f to
5a0f6fe
Compare
5a0f6fe to
06b5e1d
Compare
06b5e1d to
7d2e857
Compare
Description
Upadted version unpacking in
tags.pyto enable support for version schemes with less than 3 components.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
If version in pyproject.toml or cli argument is less than 3 components (e.g.
1,1.0) we won't getValueError: not enough values to unpack (expected 3, got N)error.Steps to Test This Pull Request
Addded new unit tests
Additional Context
#1704