[site] Simplify font loading #764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @the-other-tim-brown, this would not work due to the CSP policy in place that blocks getting content from other domains like CDNs, so the style sheets and/or JavaScript file have to be loaded from the same subdomain or others. More details can be found by analyzing the CSP here: https://csp-evaluator.withgoogle.com/ (enter https://xtable.apache.org/) 2025-12-07.21-22-06.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
@AzhanL pointed out that the site icons are not loading properly. It is due to some CSP loading issue. This PR updates the method we use to load the icons to resolve the issue.
Brief change log
Verify this pull request
Built and ran locally with the following result:
