Add support for responses API; maintain backward compatability #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vbtcl
commented
Dec 12, 2025
Comment on lines
+60
to
+92
| def _should_use_responses_api(self) -> bool: | ||
| """ | ||
| Determine if the Responses API should be used instead of Chat Completions. | ||
| The Responses API is only available on OpenAI's official endpoints. | ||
| For other providers (OpenRouter, Google AI Studio, local servers, etc.), | ||
| we must use the Chat Completions API for compatibility. | ||
| Returns: | ||
| True if Responses API should be used, False for Chat Completions | ||
| """ | ||
| # Normalize api_type (None defaults to "auto") | ||
| api_type = self.api_type if self.api_type is not None else "auto" | ||
|
|
||
| # Check for explicit override | ||
| if api_type == "responses": | ||
| return True | ||
| if api_type == "chat_completions": | ||
| return False | ||
|
|
||
| # Auto-detect based on API base URL | ||
| if not self.api_base: | ||
| return False | ||
|
|
||
| api_lower = self.api_base.lower() | ||
|
|
||
| # Only use Responses API for official OpenAI endpoints | ||
| return ( | ||
| api_lower.startswith("https://api.openai.com") or | ||
| api_lower.startswith("https://eu.api.openai.com") or | ||
| api_lower.startswith("https://apac.api.openai.com") | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
We can also delete this and force user to specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.