-
Notifications
You must be signed in to change notification settings - Fork 44k
Restructure: Group exercises by curriculum section #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Exercises dirs will no longer all be in the repo root but will be nested in dirs relating to the curriculum structure.
Exercises repo restructured in TheOdinProject/javascript-exercises#597
Uses regex, not glob (which would lead to Jest running all tests, not only solution ones)
JoshDevHub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to pretend to be an expert in the file generation stuff here, but I trust you and everything else looks good. Helps that there are tests lol.
Let's do it.
|
I could look into adding tests for the plop stuff but that'd involve a fair amount of mocking FS/stdin/stdout stuff. Easiest is to checkout this PR and run |
Because
Our JS exercises are no longer exclusive to the Foundations course. Having all exercises in the repo root would make it awkward to add new exercises in the middle. It makes sense to group exercises by curriculum section, just like the Ruby and CSS exercises repos.
This PR
foundations/computer_science/recursion/plopgenerators to allow for generating new exercises in nested dirsIssue
Closes #533
Must only be merged alongside TheOdinProject/curriculum#30480 and TheOdinProject/curriculum#30502
Additional Information
A large diff but hopefully the diffs for each commit should be easier to review.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder