Skip to content

Refactor: Improve clarity and efficiency of subset sum algorithm #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ailsonguedes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Improve clarity and efficiency of subset sum algorithm #14000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dynamic_programming/sum_of_subset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,18 @@ def is_sum_subset(arr: list[int], required_sum: int) -> bool:

for i in range(1, arr_len + 1):
for j in range(1, required_sum + 1):
if arr[i - 1] > j:
current_item_value = arr[i - 1]

# current_item_value is greater than j
if current_item_value > j:
subset[i][j] = subset[i - 1][j]
if arr[i - 1] <= j:
subset[i][j] = subset[i - 1][j] or subset[i - 1][j - arr[i - 1]]
# replace an 'if' in an 'else' to make the fluxe more clean
else:
without_current_item = subset[i - 1][j]

sum_required_if_item_taken = j - current_item_value
without_current_item = subset[i - 1][sum_required_if_item_taken]
subset[i][j] = without_current_item or without_current_item

return subset[arr_len][required_sum]

Expand Down