Skip to content

Conversation

@rclarke0
Copy link
Contributor

Overview

Uses OffsetTag to wrap LPC offsets in HistoricalProtocolRunDrawer

Test Plan and Hands on Testing

smoke tested on the app
Screenshot 2025-12-11 at 3 11 44 PM

Changelog

  • replaced LegacyOffsetVector with OffsetTag

Risk assessment

low

Closes EXEC-1891

@rclarke0 rclarke0 requested a review from mjhuff December 11, 2025 20:41
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.94%. Comparing base (3cd09f4) to head (d120ebc).
⚠️ Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
...ms/Desktop/Devices/HistoricalProtocolRunDrawer.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20356      +/-   ##
==========================================
+ Coverage   56.74%   56.94%   +0.19%     
==========================================
  Files        3648     3648              
  Lines      303616   303616              
  Branches    42711    42728      +17     
==========================================
+ Hits       172290   172893     +603     
+ Misses     131112   130504     -608     
- Partials      214      219       +5     
Flag Coverage Δ
app 46.67% <0.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ms/Desktop/Devices/HistoricalProtocolRunDrawer.tsx 0.77% <0.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, glad it was straightforward. Thank you!

@rclarke0 rclarke0 merged commit cdf9c10 into edge Dec 12, 2025
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants