Fix Tracer.currentOtelSpan to work with OTLP module #5890
+155
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 840371a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schickling
force-pushed
the
schickling/otel-currentspan-bug
branch
from
57359d3 to
9b1f94c
Compare
Make `currentOtelSpan` work with both the official OpenTelemetry SDK and the lightweight OTLP module. When using OTLP, it returns a read-only wrapper that provides `spanContext()` with the correct traceId, spanId, and traceFlags. The wrapper has no-op implementations for mutating methods since OTLP spans are managed differently. Closes #5889 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
schickling
force-pushed
the
schickling/otel-currentspan-bug
branch
from
9b1f94c to
9a19ff3
Compare
schickling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Tracer.currentOtelSpanto work with both OpenTelemetry SDK and OTLP module.Problem
Tracer.currentOtelSpandid not work with the lightweight OTLP module (OtlpTracer.layer) because it checked for a special symbol marker (OtelSpanTypeId) that OTLP spans do not have. This caused it to always returnNoSuchElementExceptionwhen using OTLP.See #5889 for details.
Solution
Make
currentOtelSpanwork with both approaches:Otel.Spanobject (unchanged behavior)spanContext()with correct traceId, spanId, traceFlagssetAttribute,addEvent, etc.)falsefromisRecording()to indicate it is not a recording spanTest plan
currentOtelSpanwith OTLP moduleCloses #5889
🤖 Generated with Claude Code