Skip to content

Commit f1c9df7

Browse files
committed
Unignore passing junit tests, fix: correctly ignore Bytecode DSL in ProfileTests
1 parent 2e52832 commit f1c9df7

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

graalpython/com.oracle.graal.python.test.integration/src/com/oracle/graal/python/test/integration/grammar/AsyncTests.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ public class AsyncTests {
5050
@Test
5151
public void nativeCoroutine() {
5252
assumeFalse(IS_WINDOWS);
53-
assumeFalse("TODO: not implemented PGenerator.getYieldFrom(PGenerator.java:204)", Boolean.getBoolean("python.EnableBytecodeDSLInterpreter"));
5453
String source = "import asyncio\n" +
5554
"async def foo():\n" +
5655
" return 42\n" +
@@ -63,7 +62,6 @@ public void nativeCoroutine() {
6362
@Test
6463
public void asyncWith() {
6564
assumeFalse(IS_WINDOWS);
66-
assumeFalse("TODO: not implemented PGenerator.getYieldFrom(PGenerator.java:204)", Boolean.getBoolean("python.EnableBytecodeDSLInterpreter"));
6765
String source = "import asyncio\n" +
6866
"class AsyncContextManager:\n" +
6967
" async def __aenter__(self):\n" +
@@ -89,7 +87,6 @@ public void asyncWith() {
8987
@Test
9088
public void asyncWithExceptional() {
9189
assumeFalse(IS_WINDOWS);
92-
assumeFalse("TODO: not implemented PGenerator.getYieldFrom(PGenerator.java:204)", Boolean.getBoolean("python.EnableBytecodeDSLInterpreter"));
9390
String source = "import asyncio\n" +
9491
"class AsyncContextManager:\n" +
9592
" async def __aenter__(self):\n" +

graalpython/com.oracle.graal.python.test.integration/src/com/oracle/graal/python/test/integration/runtime/ProfileTests.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,12 @@
4040
*/
4141
package com.oracle.graal.python.test.integration.runtime;
4242

43+
import static com.oracle.graal.python.test.integration.PythonTests.eval;
44+
4345
import java.io.ByteArrayOutputStream;
4446
import java.io.PrintStream;
4547

48+
import org.graalvm.polyglot.Value;
4649
import org.junit.Assert;
4750
import org.junit.Assume;
4851
import org.junit.Test;
@@ -68,7 +71,9 @@ public void profileYield() {
6871

6972
@Test
7073
public void profileException() {
71-
Assume.assumeFalse("TODO: wrong stacktrace", Boolean.getBoolean("python.EnableBytecodeDSLInterpreter"));
74+
Value isBytecodeDLS = eval("__graalpython__.is_bytecode_dsl_interpreter");
75+
// GR-71916
76+
Assume.assumeFalse("TODO: wrong stacktrace", isBytecodeDLS.asBoolean());
7277
String source = "import sys\n" +
7378
"def f(frame, event, arg): print(frame, event, arg)\n" +
7479
"sys.setprofile(f)\n" +

0 commit comments

Comments
 (0)