Skip to content

Commit 8e60fc8

Browse files
authored
Merge pull request #17 from mpyw/claude/php-8.5-support
[Claude] Add PHP 8.5 to CI test matrix
2 parents 38add1a + 32b6a86 commit 8e60fc8

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
2525
strategy:
2626
matrix:
27-
php: [8.2, 8.3, 8.4]
27+
php: [8.2, 8.3, 8.4, 8.5]
2828
laravel: [^11.0, ^12.0, ^13.0.x-dev]
2929
exclude:
3030
- php: 8.2

src/SystemVariableAssigner.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class SystemVariableAssigner
3232
/**
3333
* @phpstan-ignore-next-line parameterByRef.unusedType
3434
*/
35-
public function __construct(null|Closure|PDO &...$pdos)
35+
public function __construct(Closure|PDO|null &...$pdos)
3636
{
3737
$this->pdos = array_filter($pdos);
3838
}

src/Value.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static function str(string $value)
6767
*
6868
* @param bool|float|int|string $value
6969
*/
70-
public static function as(string $type, $value): ExpressionInterface
70+
public static function as(string $type, $value): ValueInterface
7171
{
7272
switch ($type) {
7373
case static::TYPE_INTEGER:

tests/BasicVariableAssignmentTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@
88
use Mpyw\LaravelMySqlSystemVariableManager\MySqlConnection;
99
use Mpyw\LaravelMySqlSystemVariableManager\Replacer;
1010
use Mpyw\LaravelMySqlSystemVariableManager\Value;
11+
use PHPUnit\Framework\Attributes\DataProvider;
1112

1213
class BasicVariableAssignmentTest extends TestCase
1314
{
1415
/**
15-
* @test
1616
* @param mixed $expectedOriginal
1717
* @param mixed $newValue
1818
* @param mixed $expectedChanged
19-
* @dataProvider provideBasicVariables
2019
*/
20+
#[DataProvider('provideBasicVariables')]
2121
public function testAssignments(string $variableName, bool $emulated, $expectedOriginal, $newValue, $expectedChanged): void
2222
{
2323
$this->{$emulated ? 'onEmulatedConnection' : 'onNativeConnection'}(function (MySqlConnection $db) use ($variableName, $expectedOriginal, $newValue, $expectedChanged): void {
@@ -28,12 +28,11 @@ public function testAssignments(string $variableName, bool $emulated, $expectedO
2828
}
2929

3030
/**
31-
* @test
3231
* @param mixed $expectedOriginal
3332
* @param mixed $newValue
3433
* @param mixed $expectedChanged
35-
* @dataProvider provideBasicVariables
3634
*/
35+
#[DataProvider('provideBasicVariables')]
3736
public function testTemporaryAssignments(string $variableName, bool $emulated, $expectedOriginal, $newValue, $expectedChanged): void
3837
{
3938
$this->{$emulated ? 'onEmulatedConnection' : 'onNativeConnection'}(function (MySqlConnection $db) use ($variableName, $expectedOriginal, $newValue, $expectedChanged): void {

0 commit comments

Comments
 (0)