build(dev-deps): upgrade eslint from v8 to v9 (#5559)

* build(dev-deps): upgrade `eslint` from v8 to v9

Signed-off-by: hainenber <dotronghai96@gmail.com>

* chore: remove newline in helpers.js

* chore: remove ignored caught error and related eslint directive

Signed-off-by: hainenber <dotronghai96@gmail.com>

* chore: restore lockfile to v2

Signed-off-by: hainenber <dotronghai96@gmail.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>

Author: hainenber

karma.conf.js

@@ -151,7 +151,7 @@ const createBundleDir = (cfg, bundleDirPath) => {
           bundleDirPath,
         },
       };
-    } catch (ignored) {
+    } catch {
       console.error(
         `Failed to create ${bundleDirPath}; using temp directory instead`,
       );

lib/cli/lookup-files.js

@@ -112,7 +112,7 @@ module.exports = function lookupFiles(
     if (stat.isFile() || stat.isFIFO()) {
       return filepath;
     }
-  } catch (err) {
+  } catch {
     // ignore error
     return;
   }
@@ -130,7 +130,7 @@ module.exports = function lookupFiles(
         }
         return;
       }
-    } catch (ignored) {
+    } catch {
       return;
     }
     if (!extensions.length) {

lib/errors.js

@@ -299,7 +299,7 @@ function createMultipleDoneError(runnable, originalErr) {
     if (runnable.parent.root) {
       title += " (of root suite)";
     }
-  } catch (ignored) {
+  } catch {
     title = format("<%s> (of unknown suite)", runnable.title);
   }
   var message = format(

lib/mocha.js

@@ -358,7 +358,7 @@ Mocha.prototype.ui = function (ui) {
     if (!bindInterface) {
       try {
         bindInterface = require(ui);
-      } catch (err) {
+      } catch {
         throw createInvalidInterfaceError(`invalid interface '${ui}'`, ui);
       }
     }

lib/nodejs/worker.js

@@ -83,9 +83,8 @@ async function run(filepath, serializedOptions = "{}") {
   }
   let argv;
   try {
-    // eslint-disable-next-line no-eval
     argv = eval("(" + serializedOptions + ")");
-  } catch (err) {
+  } catch {
     throw createInvalidArgumentValueError(
       "run() was unable to deserialize the options",
       "serializedOptions",

lib/reporters/base.js

@@ -217,7 +217,7 @@ var generateDiff = (exports.generateDiff = function (actual, expected) {
       result = `${result}\n      [mocha] output truncated to ${maxLen} characters, see "maxDiffSize" reporter-option\n`;
     }
     return result;
-  } catch (err) {
+  } catch {
     var msg =
       "\n      " +
       color("diff added", "+ expected") +

lib/runner.js

@@ -495,8 +495,8 @@ Runner.prototype.fail = function (test, err, force) {
 
       try {
         currentErr.stack = stackFilter(currentErr.stack);
-      } catch (ignore) {
-        // some environments do not take kindly to monkeying with the stack
+      } catch {
+        // Ignore error as some environments do not take kindly to monkeying with the stack
       }
 
       currentErr = currentErr.cause;

lib/utils.js

@@ -362,9 +362,9 @@ function jsonStringify(object, spaces, depth) {
  */
 exports.canonicalize = function canonicalize(value, stack, typeHint) {
   var canonicalizedObj;
-  /* eslint-disable no-unused-vars */
+
   var prop;
-  /* eslint-enable no-unused-vars */
+
   typeHint = typeHint || canonicalType(value);
   function withStack(value, fn) {
     stack.push(value);
@@ -392,12 +392,12 @@ exports.canonicalize = function canonicalize(value, stack, typeHint) {
       });
       break;
     case "function":
-      /* eslint-disable-next-line no-unused-vars, no-unreachable-loop */
+      /* eslint-disable-next-line no-unused-vars */
       for (prop in value) {
         canonicalizedObj = {};
         break;
       }
-      /* eslint-enable guard-for-in */
+
       if (!canonicalizedObj) {
         canonicalizedObj = emptyRepresentation(value, typeHint);
         break;