Skip to content

Commit 2cf1aa5

Browse files
Luke LuongArvindKa
authored andcommitted
Address comments an fix flake8 warnings
1 parent 4fa46da commit 2cf1aa5

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

microsoft/testsuites/vm_extensions/azureperformancediagnostics.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
from lisa.sut_orchestrator import AZURE
2727
from lisa.sut_orchestrator.azure.common import (
2828
AzureNodeSchema,
29+
add_system_assign_identity,
2930
check_or_create_storage_account,
3031
get_node_context,
31-
add_system_assign_identity,
3232
list_blobs,
3333
)
3434
from lisa.sut_orchestrator.azure.features import AzureExtension
@@ -60,7 +60,7 @@ def before_case(self, log: Logger, **kwargs: Any) -> None:
6060
storage account key, which we cannot use currently.
6161
Will change it back once the extension works with MSI.
6262
""",
63-
priority=5,
63+
priority=1,
6464
requirement=simple_requirement(
6565
supported_features=[AzureExtension],
6666
),
@@ -92,8 +92,12 @@ def verify_azure_performance_diagnostics(
9292
)
9393

9494
# Assign system identity to VM
95-
# This MSI will be pre-configured with the necessary role assigments to Storage Account from Subscription level
96-
# Permissions required: Storage Account Contributor, Storage Blob Data Contributor, Storage Blob Data Contributor
95+
# This MSI will be pre-configured with the necessary
96+
# role assigments to Storage Account from Subscription level
97+
# Permissions required:
98+
# Storage Account Contributor
99+
# Storage Blob Data Contributor
100+
# Storage Blob Data Contributor
97101
add_system_assign_identity(
98102
platform=platform,
99103
resource_group_name=node_context.resource_group_name,
@@ -119,7 +123,7 @@ def verify_azure_performance_diagnostics(
119123

120124
protected_settings = {
121125
"storageAccountName": storage_account_name,
122-
"authenticationType": "SystemManagedIdentity"
126+
"authenticationType": "SystemManagedIdentity",
123127
}
124128

125129
extension_result = extension.create_or_update(
@@ -174,7 +178,8 @@ def _is_supported_linux_distro(self, node: Node) -> bool:
174178
Suse: [12, 15],
175179
SLES: [12, 15],
176180
AlmaLinux: [8],
177-
CBLMariner: [2, 3], #AzureLinux uses CBLMariner class
181+
# AzureLinux uses CBLMariner class
182+
CBLMariner: [2, 3],
178183
}
179184

180185
for distro in supported_major_versions:

0 commit comments

Comments
 (0)