chore: try oxc minifier

Author: logaretm

dev-packages/rollup-utils/bundleHelpers.mjs

@@ -13,7 +13,7 @@ import {
   makeRrwebBuildPlugin,
   makeSetSDKSourcePlugin,
   makeBannerOptions,
-  makeTerserPlugin,
+  makeMinifierOptions,
 } from './plugins/index.mjs';
 import { mergePlugins, treeShakePreset } from './utils.mjs';
 
@@ -83,17 +83,18 @@ export function makeBaseBundleConfig(options) {
     output: {
       banner,
       format: 'esm',
+      minify: makeMinifierOptions(),
     },
-    plugins: [makeTerserPlugin()],
     // Don't bundle any of Node's core modules
     external: builtinModules,
   };
 
   const awsLambdaExtensionBundleConfig = {
     output: {
       format: 'esm',
+      minify: makeMinifierOptions(),
     },
-    plugins: [makeIsDebugBuildPlugin(true), makeTerserPlugin()],
+    plugins: [makeIsDebugBuildPlugin(true)],
     // Don't bundle any of Node's core modules
     external: builtinModules,
   };
@@ -146,7 +147,7 @@ export function makeBundleConfigVariants(baseConfig, options = {}) {
 
   const includeDebuggingPlugin = makeIsDebugBuildPlugin(true);
   const stripDebuggingPlugin = makeIsDebugBuildPlugin(false);
-  const terserPlugin = makeTerserPlugin();
+  const minifierOptions = makeMinifierOptions();
   const setSdkSourcePlugin = makeSetSDKSourcePlugin('cdn');
 
   // The additional options to use for each variant we're going to create.
@@ -161,15 +162,17 @@ export function makeBundleConfigVariants(baseConfig, options = {}) {
     '.min.js': {
       output: {
         entryFileNames: chunkInfo => `${baseConfig.output.entryFileNames(chunkInfo)}.min.js`,
+        minify: minifierOptions,
       },
-      plugins: [stripDebuggingPlugin, setSdkSourcePlugin, terserPlugin],
+      plugins: [stripDebuggingPlugin, setSdkSourcePlugin],
     },
 
     '.debug.min.js': {
       output: {
         entryFileNames: chunkInfo => `${baseConfig.output.entryFileNames(chunkInfo)}.debug.min.js`,
+        minify: minifierOptions,
       },
-      plugins: [includeDebuggingPlugin, setSdkSourcePlugin, terserPlugin],
+      plugins: [includeDebuggingPlugin, setSdkSourcePlugin],
     },
   };
 

dev-packages/rollup-utils/plugins/bundlePlugins.mjs

@@ -1,17 +1,5 @@
-/**
- * CommonJS plugin docs: https://github.com/rollup/plugins/tree/master/packages/commonjs
- * License plugin docs: https://github.com/mjeanroy/rollup-plugin-license
- * Replace plugin docs: https://github.com/rollup/plugins/tree/master/packages/replace
- * Resolve plugin docs: https://github.com/rollup/plugins/tree/master/packages/node-resolve
- * Terser plugin docs: https://github.com/TrySound/rollup-plugin-terser#options
- * Terser docs: https://github.com/terser/terser#api-reference
- * Typescript plugin docs: https://github.com/rollup/plugins/tree/master/packages/typescript/#readme
- */
-
 import * as childProcess from 'child_process';
-
 import { replacePlugin } from 'rolldown/plugins';
-import terser from '@rollup/plugin-terser';
 
 /**
  * Create a plugin to add an identification banner to the top of stand-alone bundles.
@@ -41,7 +29,6 @@ export function makeIsDebugBuildPlugin(includeDebugging) {
       __SENTRY_DEBUG__: JSON.stringify(includeDebugging),
     },
     {
-      // TODO `preventAssignment` will default to true in version 5.x of the replace plugin, at which point we can get rid
       // of this. (It actually makes no difference in this case whether it's true or false, since we never assign to
       // `__SENTRY_DEBUG__`, but if we don't give it a value, it will spam with warnings.)
       preventAssignment: true,
@@ -75,22 +62,18 @@ export function makeBrowserBuildPlugin(isBrowserBuild) {
       'process.env.NODE_ENV': JSON.stringify('production'),
     },
     {
-      // TODO This will be the default in the next version of the `replace` plugin
       preventAssignment: true,
     },
   );
 }
 
-// `terser` options reference: https://github.com/terser/terser#api-reference
-// `rollup-plugin-terser` options reference: https://github.com/TrySound/rollup-plugin-terser#options
-
 /**
- * Create a plugin to perform minification using `terser`.
+ * Create minifier options for the rollup build.
  *
- * @returns An instance of the `terser` plugin
+ * @returns {import('rolldown').OutputOptions['minify']}
  */
-export function makeTerserPlugin() {
-  return terser({
+export function makeMinifierOptions() {
+  return {
     mangle: {
       // `captureException` and `captureMessage` are public API methods and they don't need to be listed here, as the
       // mangler won't touch user-facing things, but `sentryWrapped` is not user-facing, and would be mangled during
@@ -136,8 +119,5 @@ export function makeTerserPlugin() {
         ],
       },
     },
-    output: {
-      comments: false,
-    },
-  });
+  };
 }

dev-packages/rollup-utils/utils.mjs

@@ -21,16 +21,7 @@ export function mergePlugins(pluginsA, pluginsB) {
     // here.
     // Additionally, the excludeReplay plugin must run before TS/Sucrase so that we can eliminate the replay code
     // before anything is type-checked (TS-only) and transpiled.
-    const order = [
-      'remove-dev-mode-blocks',
-      'excludeReplay',
-      'typescript',
-      'sucrase',
-      '...',
-      'terser',
-      'license',
-      'output-base64-worker-script',
-    ];
+    const order = ['remove-dev-mode-blocks', 'excludeReplay', '...', 'output-base64-worker-script'];
     const sortKeyA = order.includes(a.name) ? a.name : '...';
     const sortKeyB = order.includes(b.name) ? b.name : '...';
 

package.json

@@ -104,7 +104,6 @@
     "dev-packages/bundler-tests"
   ],
   "devDependencies": {
-    "@rollup/plugin-terser": "^0.4.4",
     "@size-limit/file": "~11.1.6",
     "@size-limit/webpack": "~11.1.6",
     "@types/jsdom": "^21.1.6",