Commit 7404fdc
authored
fix(core):
In the Electron SDK, we have to manually set sessions as crashed when
native crashes are encountered:
https://github.com/getsentry/sentry-electron/blob/dabd6daf0c19c2a6f224d1e721eb5d58c3cf61ac/src/main/integrations/sentry-minidump/index.ts#L175
This has the downside that if you return `null` in `beforeSend`, the
event still impacts the release health crash rate.
I found that this was required because `_updateSessionFromEvent` in
`@sentry/core` does not consider the Electron native events as a crash
or an error because there are no exceptions in the event.
This PR ensures that any event with a `fatal` level is considered a
crash.fatal events should set session as crashed (#15072)1 parent 62fdfe7 commit 7404fdc
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
758 | 758 | | |
759 | 759 | | |
760 | 760 | | |
761 | | - | |
| 761 | + | |
762 | 762 | | |
763 | 763 | | |
764 | 764 | | |
| |||
0 commit comments