Skip to content

[Bug] Pirate Weather - Icon for Windy Not Displaying #3956

@rwoberholzer

Description

@rwoberholzer

Environment

System Information

  • SYSTEM: manufacturer: Dell Inc.; model: Docker Container; virtual: false; MM: 2.33.0
  • OS: platform: linux; distro: Debian GNU/Linux; release: 12; arch: x64; kernel: 6.12.24-Unraid
  • VERSIONS: electron: undefined; used node: 22.21.1; installed node: 22.21.1; npm: 10.9.4; pm2:
  • ENV: XDG_SESSION_TYPE: undefined; MM_CONFIG_FILE: undefined
    WAYLAND_DISPLAY: undefined; DISPLAY: undefined; ELECTRON_ENABLE_GPU: undefined
  • RAM: total: 64353.27 MB; free: 50918.28 MB; used: 13435.00 MB
  • OTHERS: uptime: 9571 minutes; timeZone: America/New_York

Which start option are you using?

node --run start

Are you using PM2?

No

Module

weather

Have you tried disabling other modules?

  • Yes
  • No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • Yes

What did you do?

Configuration

{
module: "weather",
position: "bottom_right",
config: {
weatherProvider: "pirateweather",
apiBase: "https://api.pirateweather.net",
weatherEndpoint: "/forecast",
apiKey: "xxx",
lat: "xxx",
lon: "xxx",
type: "forecast",
degreeLabel: false,
tableClass: "medium",
roundTemp: true,
fade: false
}
},

// Map icons from Pirate Weather to our icons.
	convertWeatherType(weatherType) {
		const weatherTypes = {
			"clear-day": "day-sunny",
			"clear-night": "night-clear",
			rain: "rain",
			snow: "snow",
			sleet: "snow",
			wind: "wind",
			fog: "fog",
			cloudy: "cloudy",
			"partly-cloudy-day": "day-cloudy",
			"partly-cloudy-night": "night-cloudy"
		};
		return weatherTypes.hasOwnProperty(weatherType) ? weatherTypes[weatherType] : null;
	}

Steps to reproduce the issue:
Use Pirate Weather Integration weather

What did you expect to happen?

Icon for windy condition should display

What actually happened?

No icon was displayed

Additional comments

For mapping the Pirate Weather icons under convertWeatherType in pirateweather.js
wind: "wind",
should be
wind: "windy",

Participation

  • I am willing to submit a pull request for this change.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions