added checks to invalid samples

Author: keptsecret

31_HLSLPathTracer/app_resources/hlsl/next_event_estimator.hlsl

@@ -265,7 +265,7 @@ struct ShapeSampling<PST_RECTANGLE, PPM_SOLID_ANGLE>
         {
             float32_t3 sph_sample = sphUv[0] * rect.edge0 + sphUv[1] * rect.edge1 + rect.offset;
             L = sph_sample - origin;
-            L = hlsl::mix(nbl::hlsl::normalize(L), hlsl::promote<float32_t3>(0.0), hlsl::abs<float32_t3>(L) > (float32_t3)numeric_limits<float>::min); // TODO? sometimes L is vec3(0), find cause
+            L = hlsl::mix(hlsl::normalize(L), hlsl::promote<float32_t3>(0.0), hlsl::all(hlsl::abs(L) > hlsl::promote<float32_t3>(numeric_limits<float>::min))); // TODO? sometimes L is vec3(0), find cause
             pdf = 1.f / solidAngle;
         }
         else
@@ -423,9 +423,16 @@ struct Estimator<Scene, Ray, LightSample, Aniso, IM_PROCEDURAL, PST_RECTANGLE, P
 
         scalar_type pdf;
         const vector3_type sampleL = sampling.template generate_and_pdf<interaction_type>(pdf, newRayMaxT, origin, interaction, isBSDF, xi);
+        ray_dir_info_type rayL;
+        if (hlsl::isinf(pdf))
+        {
+            quotient_pdf = quotient_pdf_type::create(hlsl::promote<spectral_type>(0.0), 0.0);
+            return sample_type::createInvalid();
+        }
+
         const vector3_type N = interaction.getN();
         const scalar_type NdotL = nbl::hlsl::dot<vector3_type>(N, sampleL);
-        ray_dir_info_type rayL;
+        
         rayL.setDirection(sampleL);
         sample_type L = sample_type::create(rayL,interaction.getT(),interaction.getB(),NdotL);
 

31_HLSLPathTracer/app_resources/hlsl/pathtracer.hlsl

@@ -164,7 +164,7 @@ struct Unidirectional
             );
 
             // We don't allow non watertight transmitters in this renderer
-            bool validPath = nee_sample.getNdotL() > numeric_limits<scalar_type>::min;
+            bool validPath = nee_sample.getNdotL() > numeric_limits<scalar_type>::min && nee_sample.isValid();
             // but if we allowed non-watertight transmitters (single water surface), it would make sense just to apply this line by itself
             bxdf::fresnel::OrientedEtas<monochrome_type> orientedEta = bxdf::fresnel::OrientedEtas<monochrome_type>::create(interaction.getNdotV(), hlsl::promote<monochrome_type>(monochromeEta));
             anisocache_type _cache = anisocache_type::template create<anisotropic_interaction_type, sample_type>(interaction, nee_sample, orientedEta);
@@ -208,6 +208,9 @@ struct Unidirectional
             anisocache_type _cache;
             sample_type bsdf_sample = materialSystem.generate(bxdf.materialType, bxdf.params, interaction, eps1, _cache);
 
+            if (!bsdf_sample.isValid())
+                return false;
+
             // example only uses isotropic bxdfs
             // the value of the bsdf divided by the probability of the sample being generated
             quotient_pdf_type bsdf_quotient_pdf = materialSystem.quotient_and_pdf(bxdf.materialType, bxdf.params, bsdf_sample, interaction.isotropic, _cache.iso_cache);

31_HLSLPathTracer/main.cpp

@@ -94,7 +94,7 @@ class HLSLComputePathtracer final : public SimpleWindowedApplication, public Bui
 			if (!m_surface)
 			{
 				{
-					auto windowCallback = core::make_smart_refctd_ptr<examples::CEventCallback>(smart_refctd_ptr(m_inputSystem), smart_refctd_ptr(m_logger));
+					auto windowCallback = core::make_smart_refctd_ptr<CEventCallback>(smart_refctd_ptr(m_inputSystem), smart_refctd_ptr(m_logger));
 					IWindow::SCreationParams params = {};
 					params.callback = core::make_smart_refctd_ptr<nbl::video::ISimpleManagedSurface::ICallback>();
 					params.width = WindowDimensions.x;
@@ -121,7 +121,7 @@ class HLSLComputePathtracer final : public SimpleWindowedApplication, public Bui
 		{
 			// Init systems
 			{
-				m_inputSystem = make_smart_refctd_ptr<examples::InputSystem>(logger_opt_smart_ptr(smart_refctd_ptr(m_logger)));
+				m_inputSystem = make_smart_refctd_ptr<InputSystem>(logger_opt_smart_ptr(smart_refctd_ptr(m_logger)));
 
 				// Remember to call the base class initialization!
 				if (!device_base_t::onAppInitialized(smart_refctd_ptr(system)))